Remove %1 from [http|htmlfile]\shell\open\command

Vitaliy Margolen wine-devel at kievinfo.com
Sun Feb 5 23:03:28 CST 2006


Tuesday, January 31, 2006, 8:55:02 PM, Dmitry Timoshkov wrote:
> Hello,
> 
> the app I'm working on does:
> 
> RegCreateKeyEx(HKCR, "http\shell\open\command", &hkey);
> RegQueryValueEx(hkey, cmd);
> ShellExecute(cmd, "http://host/url");
> 
> Currently it fails under Wine because we have "winebrowser %1"
> as the command name in the registry.
> 
> A simple 5 lines long test under Windows shows that if the command
> passed to ShellExecute contains %1 after executable name it fails
> as well. Moreover, registry under Windows doesn't have %1 in
> the command name specified in http\shell\open\command.
> 
> I've also verified that it's true for htmlfile\shell\open\command as well,
> although mailto\shell\open\command has the %1 appendix in Windows.
> 
> This patch fixes my application.
> 
> Changelog:
>     Remove %1 from [http|htmlfile]\shell\open\command.

Well this patch broke functionality with other applications. And I'm not
sure that this program doing the right thing as on win2k with FireFox
installed I have
@=C:\PROGRA~1\MOZILL~1\FIREFOX.EXE -url "%1"

So we need to decide which programs do we want to brake and which
programs we want to have working.


Vitaliy Margolen






More information about the wine-devel mailing list