usp10: [RESEND] Add ScriptItemize, ScriptShape and ScriptPlace functionality

lats jeffl at yless4u.com.au
Mon Feb 13 05:22:50 CST 2006


Robert Shearman wrote:

> lats wrote:
>
>>
>> +const SCRIPT_PROPERTIES Default_Script_0 = {0, 0, 0, 0, 0, 0, 0, 0, 
>> +                                            0, 0, 0, 0, 0, 0, 0};
>>  
>>
>
> This can be "static const" instead of just "const".
>
Ok, can fix.

>>
>> +/*  Set up a sensible default and intialise pointers  */
>
>> The identation of the comment is unusual.
>
>
Get that .

>>
>> +//    pItems[0].a.eScript = SCRIPT_UNDEFINED;
>> +    pItems[0].a.eScript = 2; 
>
> Which is it, SCRIPT_UNDEFINED or 2? Decide this and remove the dead code.

Done.  Left over from testing.

Jeff



More information about the wine-devel mailing list