winbase.h dependency problems - dll separation issues

Mike McCormack mike at codeweavers.com
Mon Jan 16 07:26:56 CST 2006


winbase.h shouldn't be included when compiling ntdll, as it is the 
header for kernel32.dll.

The attached patch removes winbase.h from the server call headers, 
exposing a number of dependency problems in ntdll.

wine_server_call_err seems to be misplaced in wine/server.h as it uses 
kernel32.SetLastError(), and it is the only function which requires 
winebase.h to be included.  Perhaps it should be converted to a macro or 
only defined when winbase.h is already included, as I have done in this 
patch?

Mike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-winbase-server-call.diff
Type: text/x-patch
Size: 9063 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060116/c8a7188f/no-winbase-server-call-0001.diff


More information about the wine-devel mailing list