mscms: check an appropriate registry key.

Saulius Krasuckas saulius2 at ar.fi.lt
Wed Jan 18 17:30:10 CST 2006


* On Wed, 18 Jan 2006, James Hawkins wrote:
> * On 1/18/06, Saulius Krasuckas <saulius2 at ar.fi.lt> wrote:
> > +
> > +    hkIcmKey = reg_open_mscms_key();
> > +    if (!hkIcmKey)
> > +    {
> > +        trace("Key 'HKLM\\SOFTWARE\\Microsoft\\Windows*\\CurrentVersion\\ICM\\RegisteredProfiles' not found\n" );
> > +        return;
> > +    }
> 
> We shoul fail silently here.  If the key isn't found, just return.

Why?

> > +
> > +        ok( dwType == REG_SZ, "RegEnumValueA() returned unexpected value type (%ld)\n", dwType );
> > +        if (dwType != REG_SZ) break;
> > +        trace(" found '%s' value containing '%s' (%d chars)\n", szName, szData, strlen(szData));
> > +    }
> > +
> 
> Why do you need to output this information?  

Because I don't know what to expect in the real world. (c)

> If you're expecting certain values, do an 'ok' on them.  

When it's time, I will definitely do so. :)

> On a successful run of the tests, the only output should be the number 
> of tests that were fun, and that all of them succeeded, or if any 
> failed, output the tests that failed.

I just want to see whether (any | how much) non-standard profiles are 
listed in the key on most of the windows boxes.  Until that I see no 
ground to build my house on. :)



More information about the wine-devel mailing list