MSI: Implementation of the MsiVerifyDiskSpace function
Thomas Weidenmueller
wine-patches at reactsoft.com
Sat Jan 28 18:31:29 CST 2006
MattK wrote:
> ChangeLog:
> Implementation of the MsiVerifyDiskSpace function
>
> dlls/msi/msiquery.c | 32+-
> 1 files changed, 32 insertions(+), 0 deletions(-)
>
>
> ------------------------------------------------------------------------
>
>
This patch doesn't look right.
1. GetDiskFreeSpace is called with a uninitialized buffer
2. GetDiskFreeSpaceEx should be used to support big partitions
3. missing error checks lead to bogus calculations
4. calculating whether there's enough space is completely wrong
- Thomas
More information about the wine-devel
mailing list