[PATCH 1/2] kernel/tests: Implement safe local strcat function.

[Dmitry Timoshkov]

"Saulius Krasuckas" <saulius2 at ar.fi.lt> wrote:

>> There are other ways to achieve that. Once Alexandre already commented 
>> out an almost the same approach someone tried to port from ReactOS to 
>> Wine.
> 
> Hm, I don't remember this.  Can you give me an example of a nice way, 
> please?  It was one "if" that I removed in my patch.  Maybe you mean this 
> way?

Yes, that's a perfect way of checking for a possible buffer overflow,
there is no need to complicate things.

> If so, I don't understand how embracing every testable function call by an 
> "if" statement looks better than local strcat-wrapper.

strcat wrapper creates an illusion that it solves some problem when it
actually doesn't.

-- 
Dmitry.