Cursor patches

[Vijay Kiran Kamuju]

Hi,

These are the warnings i get when i compile ur patch
os kubuntu, gcc 4.0.3

cursoricon.c: In function 'CURSORICON_Load':
cursoricon.c:1289: warning: 'frame_bits' may be used uninitialized in
this function
mouse.c: In function 'create_cursor':
mouse.c:566: warning: pointer targets in passing argument 6 of
'XCreateImage' differ in signedness
Wine build complete.

cheers,
VJ

On 7/21/06, Dmitry Timoshkov <dmitry at codeweavers.com> wrote:
> "H. Verbeet" <hverbeet at gmail.com> wrote:
>
> > Attached is a slightly updated version of the patchset. I got rid of
> > the winmm import, and it should now destroy cursors / icons when the
> > process is destroyed. The changes are in parts 1 & 9, the rest should
> > be pretty much unchanged.
>
> I've looked only at 09_user_ani_cursor.diff.txt:
>
> 1. CURSORICON_LoadFromFile returns 0 on failure, so load_ani should return 0
> on failure as well not INVALID_HANDLE_VALUE (which usually is returned only
> for kernel objects).
>
> 2. the loop in riff_find_chunk uses memcmp to compare DWORDs, comparing
> DWORD values directly is more efficient, and alignment is not a problem
> since all the fields and chunks are DWORD aligned. Making ptr of a type
> DWORD should help with that, although that makes pointer arithmetic
> slightly more tricky, that's still will look more readable IMO.
>
> --
> Dmitry.
>
>
>