please help with patch submission

Neil Skrypuch ns03ja at brocku.ca
Mon Jul 31 07:26:18 CDT 2006


On Monday, July 31, 2006 06:37, Damjan Jovanovic wrote:
> +    WCHAR guidStringWithBraces[MAX_GUID_STRING_LEN];

You need MAX_GUID_STRING_LEN + 1 to store the null too, if I'm not mistaken.

> +    CopyMemory(&guidStringWithBraces[1], lpGuidString,
> +        (MAX_GUID_STRING_LEN - 3) * sizeof(WCHAR));

Why MAX_GUID_STRING_LEN - 3? Wouldn't that miss the last 3 characters?

- Neil



More information about the wine-devel mailing list