[Setuapi] implement SetupDiCreateDeviceInfoListExW

Juan Lang juan_lang at yahoo.com
Tue Jun 13 10:44:36 CDT 2006


Hi Christian, thanks for working on setupapi, it could use some help.  Huw
already commnented on your patch, I have a couple more:

+    if (!list) {
+        goto cleanup;
+    }

The style in this file has opening braces on lines of their own, e.g.:
     if (hInf == INVALID_HANDLE_VALUE)
     {
         return FALSE;
     }
Please stick with that.

+    if (MachineName != NULL) {

You should probably just fail if the machine name isn't NULL, since you
don't use it and you don't connect to a remote machine anyway.

--Juan

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 



More information about the wine-devel mailing list