wined3d: GLSL Patch feedback requested

[Raphael]

On Tuesday 13 June 2006 18:39, Jason Green wrote:
> On 6/13/06, H. Verbeet <hverbeet at gmail.com> wrote:
> > On 13/06/06, Raphael <fenix at club-internet.fr> wrote:
> > > I only have one  question:
> > >  i see you have a cache to reuse prgid in set_glsl_shader_program but
> > > what happens if user/app change the shaders content (for example using
> > > SetFunction) ? your pre-compiled program will be correct ?
> > > (because i don't see any list cleanup in shaders function reset)
> >
> > Good point :-)
> > I wonder if respecifying the source and recompiling the program is
> > worth it, or if we should just create a new shader object.
>
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/directx9_c
>/IDirect3DPixelShader9.asp
>
> >From what I can tell (for DX9 at least), the app shouldn't be able to
>
> use SetFunction().  I thought it was an internal wined3d function.
> Unless it's a DX8 call that I'm unaware of.  I haven't seen any apps
> try to do that yet, but maybe I'm just not looking closely enough.
>
> :-)   The apps tend to CreatePixelShader(), then later [often during
>
> the render loop], they SetPixelShader().  I haven't seen any that
> modify an existing shader yet.

No seems correct to me (from DX8-9 APIs) but never say never :)
Anyway cleaning glprograms on Delete can be a good idea :)

And we must think, for futur, about the ressources manager (was last oliver 
works). As in some cases the CG will not be able to contains all precompiled 
shaders couples, and we must swap them on need  ;)

Best Regards and thx to you two,
Raphael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060613/0221b7e3/attachment.pgp