Resend: WineD3D: pixel format cleanup

Stefan Dösinger stefandoesinger at gmx.at
Wed Jun 21 08:41:38 CDT 2006


Am Mittwoch 21 Juni 2006 15:21 schrieb Ivan Gyurdiev:
> Stefan, can you clarify what happened to the GL_SUPPORT check for
> compressed formats?
The check wheter a pixelformat is actually supported will happen in 
IWineD3DImpl_CheckDeviceFormatand createsurface should call this function to 
verify wether a format is supported. Checking if a format is supported before 
returning the gl config doesn't really make sense. If the format isn't 
supported and we ask gl for a compressed texture we will get an error 
returned and broken graphics(because we ignore gl errors generally). If we 
pass 0 instead for the gl format and internal format we will have broken 
graphics too but I don't think gl returns an error then(although I'd have to 
check the man page for that)

IWineD3DImpl_CheckDeviceFormat needs a fixup too, like whitelisting formats 
instead of blacklisting them.

Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060621/3d7d8188/attachment.pgp


More information about the wine-devel mailing list