riched20: (updated) EM_GETLINE implementation and test

Alexandre Julliard julliard at winehq.org
Mon Jun 26 06:13:18 CDT 2006


Krzysztof Foltman <wdev at foltman.com> writes:

> This is the EM_GETLINE patch from Thomas Kho, updated to current git
> and with L"" replaced by proper WCHAR array.

There are many more problems with that patch. For instance, it
shouldn't call IsWindowUnicode all the time, once is enough. Also
casting pointers to int is a bad idea (and not needed), it should use
sizeof(WCHAR) instead of hardcoding 2, and preferably use proper data
types instead of the nBPC hack.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list