patch opengl.c, wgl.c

[Leon Freitag]

> This is not a patch but rather partial reversal of the patch that caused
> this regression.
It's not a complete reversal though. That doesn't imply that it's not a fix. 
Perhaps the original patch had a bug in it.

> -    GLXDrawable drawable;
> -    enum x11drv_escape_codes escape = X11DRV_GET_GLX_DRAWABLE;
> +    Drawable drawable;
> +    enum x11drv_escape_codes escape = X11DRV_GET_DRAWABLE;

This part seems to be very interesting.

> It works for all my opengl applications, including GoogleEarth, World of 
> Warcraft (wow -opengl), Warcraft III, 3DEditor, Iconoclast, Glview
> & Moray 3.5.  Tested on latest CVS with Nvidia 
> 6800 graphics card on my 64 bit  OS, Fedora Core 4_64, AMD64. 

That's more than an argument. Yet there's no application that has been broken 
with it.

> +  if (ppfd->>dwFlags & PFD_DRAW_TO_BITMAP) {
> +    ERR("Flag not supported !\n");
> +    /* Should SetError here... */
> +    return 0;
> +  }

Well Wine should report ERRs instead of crashing with an Xlib error, shouldn't 
it?
OK, if you don't like these five lines so much, does the patch work without 
it?

Leon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20060319/cbe3cef2/attachment.pgp