user32: Make all the recently added ShowWindow tests pass in Wine

Tomas Carnecky tom at dbservice.com
Thu May 18 08:15:25 CDT 2006


Dmitry Timoshkov wrote:
> Could you try to identify which piece of the patch caused the regression?
> 

It wasn't that hard after all.. ;)

The problem seems to be the SWP_NOACTIVATE that is now added to 'swp' in
case of SW_MINIMIZE. Before your patch, SW_MINIMIZE has it's own 'case'
section, now it falls through and in 'case SW_SHOWMINNOACTIVE'
SWP_NOACTIVATE is added.

maybe change it to:

case SW_SHOWMINNOACTIVE:
    swp |= SWP_NOACTIVATE | SWP_NOZORDER;
case SW_MINIMIZE:
    swp &= ~SWP_NOACTIVATE;

but I'm not sure if this is the right solution.

tom




More information about the wine-devel mailing list