d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.

Markus Amsler markus.amsler at oribi.org
Tue Nov 28 15:05:00 CST 2006


Stefan Dösinger wrote:
> I proposed getting rid of COM some time ago, but I didn't consider that we 
> need some features like inheritance.
> 
> I think we should keep COM, but get rid of the D3D-Specific Addrefs because 
> they are different between the various versions d3d versions. So keep the 
> AddRef in IUnknown methods(QueryInterface namely), and GetParent, but do not 
> AddRef in d3d methods(SetTexture / GetTexture, ...)
> 
> Opinions?

 From my point of view (solving d3dx implicit surface refcounts) the 
GetParent AddRef is ugly. It spreads d3dx refcounting across d3dx and 
wined3d. It would be easier to only do d3dx refcounting in d3dx.

But that's only my pragmatic view, without further COM knowledge.



More information about the wine-devel mailing list