d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.

[Stefan Dösinger]

Am Dienstag 28 November 2006 22:05 schrieb Markus Amsler:
> Stefan Dösinger wrote:
> > I proposed getting rid of COM some time ago, but I didn't consider that
> > we need some features like inheritance.
> >
> > I think we should keep COM, but get rid of the D3D-Specific Addrefs
> > because they are different between the various versions d3d versions. So
> > keep the AddRef in IUnknown methods(QueryInterface namely), and
> > GetParent, but do not AddRef in d3d methods(SetTexture / GetTexture, ...)
> >
> > Opinions?
>
>  From my point of view (solving d3dx implicit surface refcounts) the
> GetParent AddRef is ugly. It spreads d3dx refcounting across d3dx and
> wined3d. It would be easier to only do d3dx refcounting in d3dx.
>
> But that's only my pragmatic view, without further COM knowledge.
Well, GetParent isn't part of IUnknown(its a wined3d invention), so from the 
COM point of view we're fine to do whatever we want with it. (Just 
QueryInterface has the rule that it addrefs the returned interface)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20061129/4ecef83f/attachment.pgp