Regression in wine in your patch.

[Konrad Materka]

Hello,
I found a regression in wine-0.9.21. Exactly in patch:
winex11.drv: Move WGL extension code to winex11.drv
12dbce5c938a060721a70411d579b4e6eec2c4a6
Background:
In Poland we have program called "Płatnik". It is very important, 
because we use this to send taxes and other stupid things. Unfortunately 
it is only for windows, it uses some weird components like MDAC, MS JET, 
Internet Explorer (MSXML3, crypto32 etc). Almost everything works (in 
fact many things doesn't work, but it is still usable).
And now what breaks this patch:
when I want to print program shows small windows with progress. Printing 
is working fine, but after this finish his work, window with progress 
should disappear. But what I get:

konrad at server:~/wine/wine-git$ ./wine "c:\platnik\p2.exe"
fixme:psdrv:PSDRV_CreateColor Colour is ff000000
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
err:syslevel:_EnterSysLevel (0x7edc0040, level 2): Holding 0x7ecb7880, 
level 3. Expect deadlock!
X Error of failed request:  BadWindow (invalid Window parameter)
   Major opcode of failed request:  20 (X_GetProperty)
   Resource id in failed request:  0x40000ac
   Serial number of failed request:  2134
   Current serial number in output stream:  2078
XIO:  fatal IO error 0 (Success) on X server ":0.0"
       after 2182 requests (2181 known processed) with 0 events remaining.
konrad at server:~/wine/wine-git$


This "fixme" message is normal, it occurs always when print and is harmless.
I've done some investigation (git bisec...) and found that your patch is 
responsible for this :)
If you need some more information, I'll provide some.

Oh, i almost forgot, my system:
Kubuntu/Ubuntu 6.06 with latest updates
X.org - 7.0 without XGL, compiz etc.
graphic: nvidia with binary drivers 1.0.8762
kernel 2.6.15-27-k7
gcc version 4.0.3 (Ubuntu 4.0.3-1ubuntu5)

I tried both binary DEB and git repository.


-- 
With kindest regards:
Konrad Materka