fix for the winemp3 module

Eric Pouech eric.pouech at wanadoo.fr
Wed Oct 18 14:24:58 CDT 2006


Mike McCormack wrote:

>
> Deun wrote:
>
>> Changelog by Denis Huguet (deun76 at yahoo.com)
>>
>> * 2006/10/17 :
>>  Major diff between winemp3's layer3.c file and the one from
>> MPlayer-1.0pre7try2/mp3lib/layer3.c for fixing decoding
>> glitches found out when opening mp3 file with GoldWave 4.21
>> with wine-0.9.22 (same with 0.9.23)
>
>
> Hi Denis,
>
> That's a big change.  It would be nicer to submit it piece by piece, 
> fix by fix, clarifying which bug you are fixing and to get rid of the 
> extraneous #if 0's and C++ comments.
>
> That would make regression analysis easier in case the patch 
> introduces a bug.
>
> thanks,
>
> Mike
>
>
>
>
also, mplayer is GPL:ed, so you cannot use their work in wine (which is 
LGPL)
so the patch has to be made from the code of the original library 
(mpglib), which is LGPL
A+



More information about the wine-devel mailing list