[PATCH 11/31] oledlg: Initial management of private structure
fordialog box control.
Huw Davies
huw at codeweavers.com
Thu Oct 19 10:29:08 CDT 2006
On Fri, Oct 20, 2006 at 12:07:14AM +0900, Dmitry Timoshkov wrote:
> "Huw Davies" <huw at codeweavers.com> wrote:
>
> > case WM_COMMAND:
> > switch(LOWORD(wp))
> > {
> > case IDOK:
> > case IDCANCEL:
> >+ if(wp == IDOK)
> >+ update_structure(hdlg, ps_struct);
> > EndDialog(hdlg, wp);
> >+ free_structure(ps_struct);
> > return TRUE;
> > }
>
> Probably moving update_structure(hdlg, ps_struct); under case IDOK:
> with falling through then could help with avoiding not entirely correct
> 'if(wp == IDOK)' since it doesn't ignore high word of wp.
True, but it gets fixed by 19/31 so it's not worth worrying about.
Huw.
--
Huw Davies
huw at codeweavers.com
More information about the wine-devel
mailing list