How to report code errors?
Alex Villacís Lasso
a_villacis at palosanto.com
Sat Sep 16 12:07:29 CDT 2006
Andrew Talbot escribió:
> How should one report minor code errors that don't necessarily produce known
> bad behaviour? To give a concrete example, in msacm32:driver.c
> acmDriverPriority(), formal parameter dwPriority is of type DWORD, which is
> unsigned, but it contains a line that reads:
>
> if (dwPriority < 0) dwPriority = -1;
>
> ... which can never happen.
>
> Bugzilla seems inappropriate, so does wine-devel. If Coverity has abandoned
> us, would it be worth having a web/wiki page for posting any such code
> anomalies, so that the knowledgable might consider fixing them?
>
> Thanks,
>
> -- Andy.
>
>
>
>
From windowssdk.msdn.microsoft.com:
> /dwPriority/
>
> New priority for a global ACM driver identifier. A zero value
> specifies that the priority of the driver identifier should remain
> unchanged. A value of 1 specifies that the driver should be placed as
> the highest search priority driver. A value of - 1 specifies that the
> driver should be placed as the lowest search priority driver.
> Priorities are used only for global drivers.
>
So -1 is actually a documented value for dwPriority. However, you are
right in that a DWORD (a typedef for an unsigned long) won't ever return
true for a comparison such as dwPriority < 0. I will prepare a patch
shortly. The wine-devel list might be actually a good place to post code
anomalies, as illustrated by the fact that it caught my attention
(because I put that code in the first place :-) ).
Alex Villacís Lasso
--
The following cryptic message was allegedly found in the inner edge of a Windows
XP installation CD:
4F6E65204F5320746F2072756C65207468656D20616C6C2C204F6E65204F5320746F2066696E6420
7468656D2C0D0A4F6E65204F5320746F206272696E67207468656D20616C6C20616E6420696E2074
6865206461726B6E6573732062696E64207468656D2E0A
It is rumored that only a true Unix Wizard can decypher this mysterious message,
which supposedly encodes the true nature and purpose of the software.
More information about the wine-devel
mailing list