msi/iTunes and questions

[Paul Vriens]

Hi,

just for fun I've tried to install iTunes 7 on a fresh .wine. According
to the AppDB this fails (one should first install QuickTime).

While going through some traces I saw something the apparently needs
this fix, but I'm no MSI-guy:

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index dad67a2..7b862fe 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -703,8 +703,8 @@ static UINT HANDLE_CustomType19(MSIPACKA
     static const WCHAR query[] = {
       'S','E','L','E','C','T',' ','`','M','e','s','s','a','g','e','`',' ',
       'F','R','O','M',' ','`','E','r','r','o','r','`',' ',
-      'W','H','E','R','E',' ','`','E','r','r','o','r','`',' ','=',' ',
-      '%','s',0
+      'W','H','E','R','E',' ','`','E','r','r','o','r','`',' ','=',' ','\'',
+      '%','s','\'',0
     };
     MSIRECORD *row = 0;
     LPWSTR deformated = NULL;

The single-quotes should be needed as the SQL statement in the trace showed:

trace:msi:MSI_DatabaseOpenViewW L"SELECT `Message` FROM `Error` WHERE
`Error` = The installlation of QuickTime did not complete successfully.
iTunes requires QuickTime." 0x6669a498

and a bit further:

err:msidb:WHERE_VerifyCondition Couldn't find column L"The"

This is just one of many issues with this installation.

Does the fix look OK? Should this be sent? If it has to be accompanied
with tests then please use the above fix at will, as I don't have the
time (nor the msi-skills to look into that).

Cheers,

Paul.