[PATCH 1/3] lz32/tests: Test more last errors set by
dmitry at codeweavers.com
Wed Sep 27 07:45:53 CDT 2006
"Saulius Krasuckas" <saulius.krasuckas at ieee.org> wrote:
> memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME);
> memset(&test, 0xA5, sizeof(test));
> full_file_path_name_in_a_CWD(filename_, expected, FALSE);
> + SetLastError(0xfaceabee);
Please use a usual value we all agreed to use: 0xdeadbeef.
It makes sense to check last error value only if an API has failed,
while you are adding last error checks everywhere. Unless you
have an application that depends on it, that's wrong.
More information about the wine-devel