Random X errors caused by recent cursor patch?

[Huw Davies]

On Sat, Apr 14, 2007 at 05:19:31AM -0700, Dan Kegel wrote:
> On 4/3/07, Huw Davies <huw at codeweavers.com> wrote:
> >> X Error of failed request:  BadPixmap (invalid Pixmap parameter)
> >>  Major opcode of failed request:  54 (X_FreePixmap)
> >>  Resource id in failed request:  0x2a0006a
> >
> >Could you see if this helps?  It looks like XRenderFreePicture
> >actually destroys the underlying pixmap, so we ended up freeing it
> >twice.
> 
> Hi Huw,
> when are you going to submit that fix?  People keep tripping over it;
> see http://bugs.winehq.org/show_bug.cgi?id=7959 and
> http://bugs.winehq.org/show_bug.cgi?id=8041

Unfortunately that patch isn't the correct fix - looking at the
XServer code it's clear that the Pixmap is correctly ref counted, so
we do indeed need to call XFreePixmap.

I think the XError is due to a race between the thread display and the
gdi display connections, but I haven't yet understood the issue well
enough to write a correct patch.

Huw.
-- 
Huw Davies
huw at codeweavers.com