Comments for a patch?

sol11x86 at comcast.net sol11x86 at comcast.net
Wed Apr 18 15:39:15 CDT 2007


I am compiling the stock current CVS 0.9.35 code on Solaris 10/X86.

I was successful in starting notedpad and winemine, so the base looks good.
I installed mozilla-win32-1.7.13-installer.exe, and am able to start mozilla.exe, 
but it  will not lookup host name, and therefore won't render any pages.  I 
saw a message about getaddrinfo not being found, and I figured out that 
configure was not correctly finding the function due to missing libraries 
(-lsocket, -lnsl)  during the test for getaddrinfo.

Once I crafted the patch below, and running autoheader/autoconf and the
configure /gmake depend && gmake, the installed wine was able to run
mozilla.exe and correctly lookup a hostname and render the page.

I'd like comments from the devel-list as this is my first patch.  Apologies
for not being in GIT format, as I don't have that working quite yet.  Patch
was crafted from a clean CVS tree against the changes using gdiff -ruN.

Notes on the patch:  I tried several autoconf configurations, but this was
the only one that correctly enabled HAVE_GETADDRINFO in config.h.
If someone has improvements on the patch, I'd appreciate it.  I'm just
not an autoconf guru.

Thanks,

Ben

---------------------------------------------

--- wine.ORIG/configure.ac      2007-04-16 08:10:24.000000000 -0400
+++ wine/configure.ac   2007-04-18 15:48:24.111885000 -0400
@@ -1165,7 +1165,6 @@
        ftruncate \
        futimes \
        futimesat \
-       getaddrinfo \
        getdirentries \
        gethostbyname \
        getnameinfo \
@@ -1247,6 +1246,13 @@
     AC_CHECK_LIB(resolv,inet_aton)
 fi

+dnl **** Check for getaddrinfo ****
+
+AC_CHECK_FUNC(getaddrinfo, [AC_DEFINE([HAVE_GETADDRINFO], [1],
+    [Defined to 1 if you have the getadrinfo function,])],
+    [AC_CHECK_LIB(socket, getaddrinfo,
+    [AC_DEFINE([HAVE_GETADDRINFO]) LIBS="-lsocket -lnsl $LIBS"], , , -lnsl)])
+
 dnl **** Check for types ****

 AC_C_CONST




More information about the wine-devel mailing list