Implements D3DRMVectorScale

Dmitry Timoshkov dmitry at codeweavers.com
Thu Apr 19 04:45:23 CDT 2007


<David.Adam at math.cnrs.fr> wrote:


> --- /dev/null
> +++ b/include/d3drmdef.h
...
> +#ifdef WIN32
> +#define D3DRMAPI  __stdcall
> +#else
> +#define D3DRMAPI
> +#endif

What's the point of the WIN32 macro test (does this mean that win64 doesn't
have stdcall decorations)? Also (I already pointed out to it) is it necessary
to introduce D3DRMAPI like microsoft header does instead of using simple WINAPI?

> --- /dev/null
> +++ b/dlls/d3drm/tests/vector.c

> +    pD3DRMVectorAdd = (void*)GetProcAddress(hmod, "D3DRMVectorAdd");
...
> +    pD3DRMVectorAdd(&r,&u,&v);

You do this in all your tests: proc = GetProcAdress("procname"); then call
the proc without any check for it being NULL. Why not link to d3drm.dll using
import library instead?

-- 
Dmitry.



More information about the wine-devel mailing list