[try2] kernel32: Add partial stub for
NeedCurrentDirectoryForExePath - what's wrong?
James Hawkins
truiken at gmail.com
Tue Apr 24 14:57:41 CDT 2007
On 4/24/07, Kirill K. Smirnov <lich at math.spbu.ru> wrote:
> Hi,
> I've sent the patch:
> http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html
> about a week ago and it has not been applied. Please, explain, what is wrong
> with it?
>
You haven't sent in any tests for this function. Is there some app
that needs it?
+ static const WCHAR env_name[] =
{'N','o','D','e','f','a','u','l','t','C','u','r','r','e','n','t','D','i','r','e','c','t','o','r','y','I','n','E','x','e','P','a','t','h',0};
That's a really long line. We try to keep the lines to a length of 80.
+ /* Check name first */
+ if (strchrW(name, '\\'))
+ return TRUE;
You should probably check name for NULL, but you'll have to test how
Windows handles this. That's a pretty bad comment too; check name for
what?
--
James Hawkins
More information about the wine-devel
mailing list