[3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF

Stefan Dösinger stefan at codeweavers.com
Wed Apr 25 04:22:51 CDT 2007


Am Mittwoch 25 April 2007 07:55 schrieb Ivan Gyurdiev:
>  > Stefan Dösinger wrote:
>
> You're returning a size_t here, which does not match the
> WINED3DERR_OUTOFVIDEOMEMORY returned on the HeapAlloc (granted, that's
> probably incorrect behavior by d3d9, but at least the return types
> should be consistent).
Ooops.

> Does that mean we'll be removing the other two versions of this code in
> existence (d3d9, and drawprim conv)?
That is the plan. With d3d9 I am not sure, because d3d9 needs a d3d9 decl. 
Either we leave d3d9 as it is, or we convert the wined3d decl to a d3d9 decl.

> By the way, who wrote the very 
> first version - I was looking through git history to figure out the
> proper copyright attribution, and it predates the git tree. I guess we
> should update the copyright in d3d9/vertexdeclaration.c to list that
> person if it isn't done already. I was just curious...
No idea either :-/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070425/8bd927b7/attachment.pgp


More information about the wine-devel mailing list