user32: LB_SETITEMDATA should return 1 on success, not 0
peter.verthez at advalvas.be
Tue Aug 14 11:38:31 CDT 2007
On Tue, 2007-08-14 at 13:39 +0200, Alexandre Julliard wrote:
> Peter Verthez <peter.verthez at advalvas.be> writes:
> > diff --git a/include/winuser.h b/include/winuser.h
> > index 4297a8d..97363e0 100644
> > --- a/include/winuser.h
> > +++ b/include/winuser.h
> > @@ -2428,6 +2428,7 @@ typedef struct tagSCROLLBARINFO
> > /* Listbox message return values */
> > #define LB_OKAY 0
> > +#define LB_SETITEMDATA_OKAY 1 /* undoc. OK return for LB_SETITEMDATA */
> Please don't invent constants that don't exist on Windows. In this
> case TRUE would work just as well.
Thanks, I've resubmitted the patch.
For your information, this fixes a problem with the MapSource
application (from Garmin) given in this bug comment:
With the patch, the AFX_COMBOBOX.HPP error doesn't occur anymore
(apparently, the application checks the return value of LB_SETITEMDATA).
More information about the wine-devel