dsound: Handle failing of IDsDriver_CreateSoundBuffer better

Vitaliy Margolen wine-devel at kievinfo.com
Sun Aug 19 21:52:42 CDT 2007


Maarten Lankhorst wrote:
> There, now hush. :p
> 
> Does 'Hardware Acceleration to Emulation' silently, without requiring of
> the user to do something.
> 
> 
> -            ERR("Could not map sound device for direct access (%s)\n", strerror(errno));
> -	    ERR("Please run winecfg, open \"Audio\" page and set\n"
> -                "\"Hardware Acceleration\" to \"Emulation\".\n");
> +            WARN("Could not map sound device for direct access (%s)\n", strerror(errno));
>              return DSERR_GENERIC;
And this really fixes the bug, doesn't just hide the error message? If it 
fixed, then there should be no messages at all. I really do not want to have 
people opening bugs because something crashes/sound doesn't work, etc.

Vitaliy



More information about the wine-devel mailing list