msi: Make MsiInstallProduct conformance test depend on proper UI level processing.

Misha Koshelev mk144210 at bcm.tmc.edu
Wed Feb 7 11:18:44 CST 2007


On Wed, 2007-02-07 at 08:33 -0600, Misha Koshelev wrote:
> Hi, just wanted to double-check with msi ppl and other wine developers
> if it's okay to add my conformance test to the test_MsiInstallProduct
> function. My reasons for doing this versus a completely separate test
> function are as follows:
> 
> 1. The test is already testing a full product install (installs files,
> services, registry values, etc) and my modification will simply result
> in either no modification to these actions if UI level processing is
> good or complete failure if it is bad, which will make the problem very
> easy to diagnose.
> 2. Looking through instructions on msdn it seems that there isn't a
> kosher way to make a very simple MSI file that just, say, writes a
> registry value (without doing costing, install validation, having a full
> features table, installing some features, etc.) which would make a
> separate function easy to implement and it does not really seem
> necessary to copy and paste the whole test_MsiInstallProduct (or
> similar) function just to check UI level processing.
> 
> I could do a separate function, it just seems unnecessary.
> 
> Misha
> 
> p.s. For some reason, I can't compile the msi crosstests (it gives an 
> error on linking with -lcabinet, whereas, say, kernel32 crosstests
> compile file), so if anyone can crosstest it for me that would be
> great :)

Alright, got the crosstest to work, no new errors with and without my
patch on Windows XP.

Misha




More information about the wine-devel mailing list