advapi32: sign-compare fixes
Vitaliy Margolen
wine-devel at kievinfo.com
Wed Feb 7 12:20:35 CST 2007
Joris Huizer wrote:
> - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName,
> + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName,
This isn't right. WideCharToMultiByte returns INT, which is signed.
> @@ -1995,11 +1995,11 @@ LookupAccountSidW(
>
> if (dm) {
> BOOL status = TRUE;
> - if (*accountSize > lstrlenW(ac)) {
> + if (*accountSize > (unsigned)lstrlenW(ac)) {
> if (account)
> lstrcpyW(account, ac);
> }
> - if (*domainSize > lstrlenW(dm)) {
> + if (*domainSize > (unsigned)lstrlenW(dm)) {
> if (domain)
> lstrcpyW(domain, dm);
> }
This isn't correct either. lstrlenW() also returns INT and you
can't just cast it to (unsigned). Unsigned what? int/long/dword?
Vitaliy.
More information about the wine-devel
mailing list