avifil32: sign-compare fixes

Alexandre Julliard julliard at winehq.org
Tue Feb 13 04:35:35 CST 2007


Joris Huizer <joris_huizer at yahoo.com> writes:

> diff --git a/dlls/avifil32/avifile.c b/dlls/avifil32/avifile.c
> index f989c79..e7b22b1 100644
> --- a/dlls/avifil32/avifile.c
> +++ b/dlls/avifil32/avifile.c
> @@ -835,7 +835,7 @@ static LONG WINAPI IAVIStream_fnFindSamp
>  	ULONG n;
>  
>  	for (n = 0; n < This->sInfo.dwFormatChangeCount; n++)
> -	  if (This->idxFmtChanges[n].ckid >= pos) {
> +	  if (This->idxFmtChanges[n].ckid >= (ULONG)pos) {

Please don't add typecasts all over the place. If things can be fixed
by changing variable types then that's fine, but otherwise we can just
as well live with the warnings.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list