resend : gdi32:WidenPath partial implementation

Alexandre Julliard julliard at winehq.org
Wed Feb 21 06:14:47 CST 2007


Laurent Vromman <laurent at vromman.org> writes:

> +
> +    dc = DC_GetDCPtr( hdc );

You shouldn't need that, the caller has done it already. Simply pass a
DC* to this function.

> +    if(pPath->state != PATH_Closed) {
> +       ERR("Path Closed\n");
> +       return FALSE;
> +    }
> +
> +    hPen = SelectObject(hdc, GetStockObject(DC_PEN));

You shouldn't select a new pen into the DC, just use the current one.

> +            case PT_BEZIERTO:
> +                // should never happen because of the FlattenPath call

Please avoid C++ comments.

> +            default:
> +                ERR("Got path flag %d\n", (INT)pPath->pFlags[i]);

Please avoid casts like this, use the correct printf format instead.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list