Patch to make X11DRV_GetAsyncKeyState work for TacOps

[Martin Cracauer]

Mike McCormack wrote on Thu, Jan 25, 2007 at 06:42:25PM +0900: 
> 
> Martin Cracauer wrote:
> 
> >The game "TacOps" (a standalone 2D wargame, not to be mixed up with
> >the Unreal mod "Tac Ops") uses home-grown scrollbars.  They have
> >autorepeat, that means holding the mouse button on the "down" or "up"
> >icons will continue to scroll until you release the button.  Without
> >the appended patch Wine will never notice when you release the mouse
> >button.  That effectively means an application hang since you can
> >never do anything else anymore, as the game continue to execute "down"
> >autorepeat.
> 
> You'll probably need Alexandre's comment on this, but it doesn't look 
> correct to me.
> 
> Querying the X server for the key state on each call to GetAsyncKeyState 
> bypasses the input queue, and is likely to cause applications that poll 
> GetAsyncKeyState to slow down...

I have seen in other parts of the code that a call like mine is only
made no more often than 100msec.

That will still cause a systemcall for getting the time, but it'll
probably fix my application problem (at work right now, can't test)
and at the same time make the code much lighter so that polling
GetAsyncKeyState won't slow down.

Does that sound better?

Also keep in mind I only query the X11 server when the keycode is one
of a selected few.  Combined with a 100msec cap that should keep the
extra load down.

> This is likely to be a tricky problem to solve, as you need to run 
> Wine's X11 message loop, but Wine currently only does that when the 
> application waits for input.

The application is just sitting in the GUI waiting for me to poke
around.  But it is one of those applications with permanent 100% CPU
load, so it is clearly not doing some select() equivalent.

Martin
-- 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Martin Cracauer <cracauer at cons.org>   http://www.cons.org/cracauer/
FreeBSD - where you want to go, today.      http://www.freebsd.org/