programs/winefontcfg: Add winefontcfg
ncliang at google.com
Thu Jul 12 01:20:10 CDT 2007
On 7/11/07, Dmitry Timoshkov <dmitry at codeweavers.com> wrote:
> "Dan Kegel" <dank at kegel.com> wrote:
> > I think those static function prototypes in winefontcfg.h should not be there.
> > .h files are for things shared between files;
> > your prototypes were probably put there to
> > avoid compiler errors. Better to put them in the .c file
> > if they're not used by multiple files.
> Or even better completely avoid forward declarations by properly
> arranging internal functions. winefontcfg.h is not needed at all.
> Some other comments: INT_PTR is not appropriate return type for window
> procs, global variables should be made static.
Sent in try 2: http://www.winehq.org/pipermail/wine-patches/2007-July/041356.html
Thanks for the comments!
More information about the wine-devel