[advapi32/service] Test for duplicate displayname

James Hawkins truiken at gmail.com
Wed Jul 18 12:07:34 CDT 2007


On 7/18/07, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
> Paul Vriens wrote:
> > James Hawkins wrote:
> >> On 7/17/07, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
> >>> Hi,
> >>>
> >>> Another test that shows that windows checks if the displayname
> >>> already exists.
> >>>
> >>> Changelog
> >>>     Test for duplicate displayname
> >>>
> >>> Cheers,
> >>>
> >>
> >> +    /* To find an existing displayname we check the 'Spooler'
> >> service. Although the registry doesn't show DisplayName on NT4, this
> >> call
> >>
> >> That's a really long comment at 136 cols.  There are other really long
> >> lines in the rest of the patch too.
> >>
> > Hi James,
> >
> > I already thought about that. I'll produce a cleanup patch first before
> > introducing new stuff (just have to wait if this one will be committed
> > or not).
> >
> > Cheers,
> >
> > Paul.
> >
> Just a question, what would be a good 'cutting' point? (80 chars? , 128 ?)
>

80 is pretty standard in Wine, though the occasional line is a little
bit longer, but not by much, and usually only because it would be hard
to read if the line were split up.

-- 
James Hawkins



More information about the wine-devel mailing list