[PATCH try2 2/2] winemenubuilder: Wait for application icons to be created instead of adding a RunOnce entry that may never run.

Misha Koshelev mk144210 at bcm.edu
Wed Jun 27 07:57:12 CDT 2007


On Wed, 2007-06-27 at 12:37 +0200, Hans Leidekker wrote:
> On Wednesday 27 June 2007, Misha Koshelev wrote:
> 
> +    /* Now watch the directory for our path to be created */
> +    if ((*handles = FindFirstChangeNotificationW(dir, subtree, FILE_NOTIFY_CHANGE_FILE_NAME)) ==
> +        INVALID_HANDLE_VALUE)
> 
> I'm not sure if file change notifications are the right solution here
> but since they are only supported on Linux you should at least keep the
> run once key as a fallback strategy.
> 
>  -Hans

Hmm... I was not aware of this (that means that make change.ok in
dlls/kernel32/tests fails on non-Linux systems?). What happens in these
other non-Linux systems... does FindFirstChangeNotification return
INVALID_HANDLE_VALUE or succeed and just never satisfy the wait
condition?

The good thing about the __wine_make_system_process wait we are also
waiting for is that it will get satisfied when all user processes have
closed and create links then as well. This is actually sufficient in
itself for some installers (Vector NTI), but not others that launch apps
while installing (iTunes). Perhaps I can add a long timeout to the wait
to account for these other non-Linux platforms...

Anyhow, please let me know about the behavior of
FindFirstChangeNotification on these other systems or where I can find
this documented...

Misha



More information about the wine-devel mailing list