(resend) Scroll window fix
Aric Stewart
aric at codeweavers.com
Sat Mar 3 04:50:34 CST 2007
I did my work comparing to windows 2000. I could not get the test to
run at all on my windows box so i had to try to fiddle with the test to
get it to work. I spent a lot of time working on windows 2000 to make
this behavior the same and so feel the patch is not "obviously
incorrect" and most likely I did something incorrect in the test.
-aric
Dmitry Timoshkov wrote:
> "Aric Stewart" <aric at codeweavers.com> wrote:
>
>> + SetRect( &rc, 0,40, 100,60);
>> + SetRect( &cliprc, 0,0, 100,100);
>> + ScrollWindowEx( hwnd1, 0, -25, &rc, &cliprc, hrgn, &rcu,
>> SW_INVALIDATE);
>> + SetRectRgn( tmprgn, 0,15,98,35);
>> + CombineRgn( exprgn, exprgn, tmprgn, RGN_OR);
>> + SetRectRgn( tmprgn, 0, 40, 98, 60);
>> + CombineRgn( exprgn, exprgn, tmprgn, RGN_OR);
>> + ok( EqualRgn( exprgn, hrgn), "wrong update region in excessive
>> scroll\n");
>
> Under which version of Windows this was tested? According to
> test.winehq.org this test
> doesn't pass under any of Win98, NT4, Win2000 nor XP invalidating the
> (now committed) fix.
> I'd vote to revert this patch as obviously incorrect.
>
More information about the wine-devel
mailing list