user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

Jan Zerebecki jan.wine at zerebecki.de
Thu Mar 8 13:41:30 CST 2007


On Thu, Mar 08, 2007 at 05:08:46PM +0100, Felix Nawothnig wrote:
> Jan Zerebecki wrote:
> >             CREATESTRUCTA *cs = (CREATESTRUCTA *)lParam;
> >             /* check for string, as static icons, bitmaps (SS_ICON, 
> >             SS_BITMAP)
> >              * may have child window IDs instead of window name */
> >-            if (HIWORD(cs->lpszName))
> >+            if (cs && HIWORD(cs->lpszName))
> 
> cs is never NULL at that point.

Where should it be checked for NULL, then? Or what does it prevent to be
NULL?


Jan

PS: please respect Mail-Followup-To, see http://cr.yp.to/proto/replyto.html




More information about the wine-devel mailing list