shell32: check cbSize in Shell_NotifyIconW to make apps sending garbage work (fixes bug #7940)

Dmitry Timoshkov dmitry at codeweavers.com
Sun May 6 02:55:30 CDT 2007


"Mikolaj Zalewski" <mikolaj at zalewski.pl> wrote:

> +    /* The validation is also done in explorer. However we must also do it
> +     * on the client size so that WM_COPYDATA doesn't crash the application
> +     */
> +    if (nid->cbSize != NOTIFYICONDATAW_V1_SIZE &&
> +        nid->cbSize != NOTIFYICONDATAW_V2_SIZE &&
> +        nid->cbSize != NOTIFYICONDATAW_V3_SIZE &&
> +        nid->cbSize != sizeof(NOTIFYICONDATAW))
> +    {
> +        WARN("Invalid size\n");
> +        return FALSE;
> +    }

Do you have a test case for this?

-- 
Dmitry.



More information about the wine-devel mailing list