[PATCH] initialize pSurface, since we process it on failure
Stefan Dösinger
stefan at codeweavers.com
Sat May 12 04:51:18 CDT 2007
Am Samstag 12 Mai 2007 11:39 schrieb Marcus Meissner:
> Hi,
>
> Not sure if we should perhaps not do the ICOM CAST magic on a failing
> CreateSurface call here.
>
> But initializing pSurface to NULL also helps.
The ICOM_CAST thing should set the output to NULL of the surface returned by
ddraw7_CreateSurface is NULL, but ddraw7 doesn't always set it to NULL. I
wanted to write a test for this because some calls leave the output pointer
untouched if they fail and some set it to NULL. AJ also says we should
replace transgamings com casting macros with inline functions.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070512/70c8749d/attachment.pgp
More information about the wine-devel
mailing list