[PATCH 2/8] msi/tests: automation: Add test for Installer::InstallProduct.

[Misha Koshelev]

On Mon, 2007-05-14 at 10:41 -0600, James Hawkins wrote:
> On 5/14/07, Misha Koshelev <mk144210 at bcm.edu> wrote:
> > ---
> >  dlls/msi/tests/automation.c |  307 ++++++++++++++++++++++++++++++++++++++++++-
> >  1 files changed, 300 insertions(+), 7 deletions(-)
> >
> 
> +    /* Installer::ProductState for our product code, which has been
> installed */
> +    hr = Installer_ProductState(szProductCode, &iValue);
> +    ok(SUCCEEDED(hr), "Installer_ProductState failed, hresult 0x%08x\n", hr);
> +    if (SUCCEEDED(hr))
> +        todo_wine ok(iValue == INSTALLSTATE_DEFAULT,
> "Installer_ProductState returned %d, expected %d\n", iValue,
> INSTALLSTATE_DEFAULT);
> 
> If you're assuming that hr SUCCEEDED (which you are by putting that
> check in ok), then you shouldn't condition the next ok on
> SUCCEEDED(hr).
> 

Good point.

Misha