[PATCH 1/6] msi: automation: Condense a few loops.

Misha Koshelev mk144210 at bcm.edu
Tue May 15 19:31:37 CDT 2007


On Tue, 2007-05-15 at 16:35 -0500, James Hawkins wrote:
> On 5/15/07, Misha Koshelev <mk144210 at bcm.edu> wrote:
> > ---
> >  dlls/msi/automation.c |   30 ++++++++++++------------------
> >  1 files changed, 12 insertions(+), 18 deletions(-)
> >
> 
> --- a/dlls/msi/automation.c
> 
> +++ b/dlls/msi/automation.c
> 
> @@ -580,16 +580,13 @@ static HRESULT WINAPI RecordImpl_Invoke(
> 
>                  if (FAILED(hr)) return hr;
> 
>                  V_VT(pVarResult) = VT_BSTR;
> 
>                  V_BSTR(pVarResult) = NULL;
> 
> -		ret = MsiRecordGetStringW(This->msiHandle, V_I4(&varg0), NULL, &dwLen);
> 
> -                if (ret == ERROR_SUCCESS)
> 
> +		if ((ret = MsiRecordGetStringW(This->msiHandle, V_I4(&varg0), NULL,
> &dwLen)) == ERROR_SUCCESS)
> 
>                  {
> 
> Did you mean to mix tabs and spaces in your own file?  You should
> probably stick with one or the other (preferably spaces to keep with
> the rest of msi).
> 

Will do spaces to conform with rest of msi. 

Misha



More information about the wine-devel mailing list