libs/wine: Avoid compiler warnings about unused parameter(-W)

Michael Stefaniuc mstefani at redhat.com
Sun Nov 4 20:20:52 CST 2007


Detlef Riekenberg wrote:
> Changelog:
> libs/wine: Avoid compiler warnings about unused parameter(-W)
> 
> 
> The code-sequence is optimized away.
> Another option would be "__attribute__((unused__))"
> or removing the function.
> 
> ------------------------------------------------------------------------
> 
> From b865b71aff3b8b9c43dffe93f8f0de874cccab53 Mon Sep 17 00:00:00 2001
> From: Detlef Riekenberg <wine.dev at web.de>
> Date: Sun, 4 Nov 2007 12:58:39 +0100
> Subject: [PATCH] libs/wine: Avoid compiler warnings about unused parameter(-W)
> ---
>  libs/wine/debug.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/libs/wine/debug.c b/libs/wine/debug.c
> index 67cc172..5fc56e7 100644
> --- a/libs/wine/debug.c
> +++ b/libs/wine/debug.c
> @@ -261,6 +261,8 @@ static char *get_temp_buffer( size_t siz
>  static void release_temp_buffer( char *buffer, size_t size )
>  {
>      /* don't bother doing anything */
> +    buffer = buffer;
> +    size = size;
That's just ugly. If removing the function is not an option leaving the 
function as is is the best approach.
-W is the old name for the gcc argument; the new name for it is -Wextra 
which describes the warnings better: extra warnings; might be legit but 
can be bogus.

>  }

bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani at redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart



More information about the wine-devel mailing list