advapi32/service.c -- remove untriggerable check

Dan Kegel dank at kegel.com
Sun Nov 18 11:46:44 CST 2007


Uwe wrote:
>Gerald Pfeifer writes:
>
>> n is of type DWORD which is unsigned, so n < 0 always will
>> evaluate to false.
>
> Is dropping the check the right answer? Shouldn't the check test for high
> values like > 0xff00 and report a possible problem?

Indeed.
IMHO we don't need patches like this, and Gerald
is not thinking hard enough.   Simplistic just-remove-the-warning
patches are a Bad Thing, and we Don't Want To Encourage Them.
Please stop.
- Dan

-- 
Wine for Windows ISVs: http://kegel.com/wine/isv



More information about the wine-devel mailing list