[PATCH] wininet: Conformance test for InternetCrackUrlA (try 2)

Detlef Riekenberg wine.dev at web.de
Thu Oct 18 14:15:48 CDT 2007


On Mi, 2007-10-17 at 13:17 -0700, Nigel Liang wrote:
> +  urlCompa.dwStructSize = sizeof(urlCompa);
> +  bRet = InternetCrackUrlA(sUrl, 11, 0, &urlCompa);

> +  ZeroMemory(&urlCompa, sizeof(urlCompa));
> +  ZeroMemory(&szBuf, sizeof(char)*1024);

> +  urlCompa.dwUserNameLength = 1024; 

It looks much better, when you avoid constant numbers.
I suggest to use sizeof() instead.
(but never use "sizeof()" in "ok()" or in "trace()".)

Thanks for helping wine.

-- 
 
By by ... Detlef





More information about the wine-devel mailing list