[4/5] WineD3D: Enable the draw buffers extension only when used

[H. Verbeet]

On 22/10/2007, Stefan Dösinger <stefan at codeweavers.com> wrote:
> Am Montag, 22. Oktober 2007 14:57:40 schrieb H. Verbeet:
> > On 22/10/2007, Stefan Dösinger <stefan at codeweavers.com> wrote:
> > > The shader works in the end, but the complaints pollute the logs and
> > > make tracking real failures more difficult.
> >
> > I don't think this change makes things better there.
> One issue is that those ignorable warnings spam the debug output and make it
> difficult to spot real warnings. The draw_buffer warning is only one of them,
> Apple also warns about BindAttribLocation calls for undefined Attributes. At
> some point the driver seems to cut off further warnings, so real issues get
> lost.
>
> My other concern is that some GL implementations do not realize that
> draw_buffers isn't really used, and turns on things we do not need because we
> request the extension. I doubt this applies to macos, its optimizer is quite
> sane as far as I can see.
>
> I agree that this patch makes the glsl code a bit more complex, and I am fine
> with keeping it in my junk branch. But I think having it in the tree makes
> the life easier for newcomer developers and users by making sure they don't
> get flooded with false warnings. (Not that we have any mac d3d developers
> except me, but false warnings won't help with that).
>
Probably, but the warnings are a driver problem, not a wined3d
problem. The really bad part is that if the drivers ever get fixed we
end up with workarounds for problems that no longer exist.