Start: Convert start to Unicode.
dmitry at codeweavers.com
Thu Oct 25 07:52:35 CDT 2007
"Anatoly Lyutin" <vostok at etersoft.ru> wrote:
>> Once you change your editor settings to use natural 8 spaces for a tab
>> you will
>> see how ugly the formatting in your new code is.
> I am sorry. I forgot that in the start.c uses natural 8 spaces for a
> tab. Fixed.
The whole Wine tree uses 8 spaces for a tab.
>>> -static void fatal_error(const char *msg, DWORD error_code)
>>> +static void fatal_error(const WCHAR *msg, DWORD error_code)
>> fatal_error() is not called with strings outside of ASCII charset, so
>> there is no much point in converting it to unicode. It only makes your
>> patch full of controversial changes. IMHO fatal_error() should be removed
>> altogether, and replaced by proper error handling instead.
> I think that it is the question of time. For example In the future these
> messages will be probably deduced in the Korean (or Japanese or etc)
> But what proper error handling do you mean?Should I use a FIXME, ERR and
> so on?
A proper error handling IMO is to return an error to the caller instead
of terminating the app.
More information about the wine-devel