Make test - opengl regression

[Austin English]

On Wed, Apr 2, 2008 at 5:05 PM, Austin English <austinenglish at gmail.com> wrote:
> Running on my virtualbox feisty vm, seems make test is making some progress:
>
>  austin at austin-desktop:~/wine-git$ cat wine-0.9.58-439-g73bd68c.txt |
>  grep 'make.*Error'
>  make[2]: *** [exception.ok] Error 1
>  make[1]: *** [ntdll/tests/__test__] Error 2
>  make[2]: *** [opengl.ok] Error 1
>  make[1]: *** [opengl32/tests/__test__] Error 2
>  make[2]: *** [msg.ok] Error 24
>  make[1]: *** [user32/tests/__test__] Error 2
>  make: *** [dlls/__test__] Error 2
>
>  The visual.c's are skipping properly now for me, but there's a
>  regression in opengl/opengl.c.
>
>  ../../../tools/runtest -q -P wine -M opengl32.dll -T ../../.. -p
>  opengl32_test.exe.so opengl.c && touch opengl.ok
>  err:wgl:X11DRV_wglCreateContext Cannot get FB Config for iPixelFormat
>  0, expect problems!
>  opengl.c:248: Test failed: Unable to confirm DONTCARE behavior of
>  unset pixelformatdescriptor flags
>  err:wgl:X11DRV_SetPixelFormat Invalid operation on root_window
>  opengl.c:323: Tests skipped: No suitable pixel formats found
>  make: *** [opengl.ok] Error 1
>
>  I haven't ran a regression test yet, but if you want more logs or a
>  regression test, let me know.
>

Seems Roderick's recent  wgl: Fix ChoosePixelFormat behavior patch is
to blame. Before, it would simply skip on failure, now I get a make
error. Is a skip() possible for this case?

http://source.winehq.org/git/wine.git/?a=commit;h=616ac380f9a1ed4e83f0159f4cc9768bad8b4a68