dinput: Implement DIPROP_KEYNAME property for keyboard device
Vitaliy Margolen
wine-devel at kievinfo.com
Sun Apr 13 13:15:30 CDT 2008
Sergey Khodych wrote:
>
>
> ------------------------------------------------------------------------
>
>
> +static HRESULT WINAPI SysKeyboardAImpl_GetProperty(
> ...
> + if (TRACE_ON(dinput))
> + _dump_DIPROPHEADER(pdiph);
Please drop the TRACE_ON check - it's being done in dump function.
> ...
> + hr = SysKeyboardWImpl_GetObjectInfo( (LPDIRECTINPUTDEVICE8W)iface , &didoi,
> + ps->diph.dwObj, ps->diph.dwHow );
You mixing unicode and ascii. Also if you are implementing
SysKeyboardAImpl_GetProperty you should also implement it's unicode
counterpart SysKeyboardWImpl_GetProperty.
And please use 4-space indent.
Vitaliy.
More information about the wine-devel
mailing list